From 0b838882a2524d88c322e48ef1cd83dcf1f23f41 Mon Sep 17 00:00:00 2001
From: Jean-Paul Calderone <exarkun@twistedmatrix.com>
Date: Mon, 2 Dec 2019 10:03:38 -0500
Subject: [PATCH] an explanation and a disclaimer

---
 nixos/modules/tests/private-storage.nix | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/nixos/modules/tests/private-storage.nix b/nixos/modules/tests/private-storage.nix
index 6b75611a..4570d462 100644
--- a/nixos/modules/tests/private-storage.nix
+++ b/nixos/modules/tests/private-storage.nix
@@ -133,6 +133,14 @@ import <nixpkgs/nixos/tests/make-test.nix> {
       };
     } // networkConfig;
 
+    # Also run a fake Stripe API endpoint server.  Nodes in these tests run on
+    # a network without outside access so we can't easily use the real Stripe
+    # API endpoint and with this one we have greater control over the
+    # behavior, anyway, without all of the unintentional transient network
+    # errors that come from the public internet.  These tests *aren't* meant
+    # to prove PaymentServer correctly interacts with the real Stripe API
+    # server so this is an unverified fake.  The PaymentServer test suite
+    # needs to take care of any actual Stripe API integration testing.
     "api_stripe_com" =
     { config, pkgs, ... }:
       let python = pkgs.python3.withPackages (ps: [ ps.twisted ]);
-- 
GitLab