From a039e35f3701800d8e6889957ab24c2b0865ced5 Mon Sep 17 00:00:00 2001
From: Jean-Paul Calderone <exarkun@twistedmatrix.com>
Date: Mon, 8 May 2023 10:06:30 -0400
Subject: [PATCH] I'm not convinced this adds any value beyond the existing
success case
StorageServer hides all of the networking details in the real implementation.
If tahoe-great-black-swamp works then the existing success case should
exercise all of the same logic in gbs-downloader whether we're actually using
it or not...
It might be nice to move all of the StorageServer implementations into
gbs-downloader and then test that they really do behave the same as each
other. Right now they're mostly in tahoe-chk though so that's annoying.
---
test/Spec.hs | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/test/Spec.hs b/test/Spec.hs
index 9d92fbe..49e0f85 100644
--- a/test/Spec.hs
+++ b/test/Spec.hs
@@ -290,16 +290,6 @@ tests =
-- Consider moving these tests to another module, they're pretty
-- different and there's quite a handful of them.
--
- -- SUCCESS CASE
- -- Make an in-memory GBS backend
- -- Encode some data to shares
- -- Store the shares on the backend
- -- Wrap an HTTPS server around the backend
- -- Get its FURL
- -- Make an announcement for it
- -- Give the announcement and the cap to the download function
- -- Assert we recovered the plaintext
- --
-- ERROR CASES
-- Server presents incorrect TLS certificate
-- Server returns error response to our request
--
GitLab