From 29d9d7a2165c0ec883b5c5e43350a6395cff855d Mon Sep 17 00:00:00 2001
From: Jean-Paul Calderone <exarkun@twistedmatrix.com>
Date: Fri, 11 Jun 2021 15:43:51 -0400
Subject: [PATCH] Test one more failure codepath
---
test/FakeStripe.hs | 19 +++++++++++++++++++
test/Stripe.hs | 19 +++++++++++++------
2 files changed, 32 insertions(+), 6 deletions(-)
diff --git a/test/FakeStripe.hs b/test/FakeStripe.hs
index f1040b5..dec4646 100644
--- a/test/FakeStripe.hs
+++ b/test/FakeStripe.hs
@@ -4,6 +4,7 @@
module FakeStripe
( withFakeStripe
, chargeOkay
+ , chargeFailed
) where
import Text.RawString.QQ
@@ -23,6 +24,7 @@ import Data.Time.Calendar
import Network.HTTP.Types
( status200
+ , status400
)
import Network.Wai
@@ -41,6 +43,17 @@ import Web.Stripe.Client
, Endpoint(Endpoint)
)
+anError :: ByteString
+anError = [r|
+{
+ "error": {
+ "type": "card_error",
+ "code": "expired_card",
+ "message": "Your card is expired."
+ }
+}
+|]
+
aCharge :: ByteString
aCharge = [r|
{
@@ -138,11 +151,17 @@ aCharge = [r|
}
|]
+
+
-- Accept a charge creation and respond in the affirmative.
chargeOkay :: Application
chargeOkay req respond =
respond . responseLBS status200 [] $ aCharge
+chargeFailed :: Application
+chargeFailed req respond =
+ respond . responseLBS status400 [] $ anError
+
-- Pass a Stripe-flavored configuration for a running Wai application to a
-- function and evaluate the resulting IO action.
withFakeStripe :: IO Application -> (StripeConfig -> IO a) -> IO a
diff --git a/test/Stripe.hs b/test/Stripe.hs
index 57fe647..2325dda 100644
--- a/test/Stripe.hs
+++ b/test/Stripe.hs
@@ -70,6 +70,7 @@ import PaymentServer.Server
import FakeStripe
( withFakeStripe
, chargeOkay
+ , chargeFailed
)
tests :: TestTree
@@ -82,13 +83,19 @@ corsTests :: TestTree
corsTests =
testGroup "CORS"
[ testCase "a request with the wrong content-type receives a CORS-enabled response" $
- assertCORSHeader "POST" textPlain validChargeBytes
+ assertCORSHeader chargeOkay "POST" textPlain validChargeBytes
+
, testCase "a request without a valid charge in the body receives a CORS-enabled response" $
- assertCORSHeader "POST" applicationJSON invalidChargeBytes
+ assertCORSHeader chargeOkay "POST" applicationJSON invalidChargeBytes
+
, testCase "a request with the wrong request method receives a CORS-enabled response" $
- assertCORSHeader "GET" applicationJSON validChargeBytes
+ assertCORSHeader chargeOkay "GET" applicationJSON validChargeBytes
+
+ , testCase "a request associated with an error from Stripe receives a CORS-enabled response" $
+ assertCORSHeader chargeFailed "POST" applicationJSON validChargeBytes
+
, testCase "a request with a valid charge in the body receives a CORS-enabled response" $
- assertCORSHeader "POST" applicationJSON validChargeBytes
+ assertCORSHeader chargeOkay "POST" applicationJSON validChargeBytes
]
where
textPlain = [("content-type", "text/plain")]
@@ -96,8 +103,8 @@ corsTests =
validChargeBytes = "{\"token\": \"abcdef\", \"voucher\": \"lmnopqrst\", \"amount\": \"650\", \"currency\": \"USD\"}"
invalidChargeBytes = "[1, 2, 3]"
- assertCORSHeader method headers body =
- withFakeStripe (return chargeOkay) $
+ assertCORSHeader stripeResponse method headers body =
+ withFakeStripe (return stripeResponse) $
\stripeConfig -> do
db <- memory
let origins = ["example.invalid"]
--
GitLab