From 243bad8f945d738d06e20b2182c0024708d50019 Mon Sep 17 00:00:00 2001
From: Jean-Paul Calderone <exarkun@twistedmatrix.com>
Date: Mon, 27 Sep 2021 11:00:41 -0400
Subject: [PATCH] call out the fact that it's StringIO.StringIO here, and say
why
---
src/_zkapauthorizer/tests/test_plugin.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/_zkapauthorizer/tests/test_plugin.py b/src/_zkapauthorizer/tests/test_plugin.py
index 3402596..5de8f41 100644
--- a/src/_zkapauthorizer/tests/test_plugin.py
+++ b/src/_zkapauthorizer/tests/test_plugin.py
@@ -400,6 +400,11 @@ class ClientPluginTests(TestCase):
# On Tahoe-LAFS <1.16, the config is written as bytes.
# On Tahoe-LAFS >=1.16, the config is written as unicode.
#
+ # So we'll use `StringIO.StringIO` (not `io.StringIO`) here - which
+ # will allow either type (it will also implicitly decode bytes to
+ # unicode if we mix them, though I don't think that should happen
+ # here).
+ #
# After support for Tahoe <1.16 support is dropped we probably want to
# switch to an io.StringIO here.
config_text = StringIO()
--
GitLab