From 3ab1b2fdfa5392ae4b1ba501f4a213f9123950b0 Mon Sep 17 00:00:00 2001 From: Jean-Paul Calderone <exarkun@twistedmatrix.com> Date: Fri, 10 Dec 2021 16:32:53 -0500 Subject: [PATCH] rename `_get_buckets` to something reflecting metricsyness --- src/_zkapauthorizer/_storage_server.py | 4 ++-- src/_zkapauthorizer/tests/test_storage_server.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/_zkapauthorizer/_storage_server.py b/src/_zkapauthorizer/_storage_server.py index 4ded5af..6d0e314 100644 --- a/src/_zkapauthorizer/_storage_server.py +++ b/src/_zkapauthorizer/_storage_server.py @@ -201,7 +201,7 @@ class ZKAPAuthorizerStorageServer(Referenceable): ) _metric_spending_successes = attr.ib(init=False) - def _get_buckets(self): + def _get_spending_histogram_buckets(self): """ Create the upper bounds for the ZKAP spending histogram. """ @@ -227,7 +227,7 @@ class ZKAPAuthorizerStorageServer(Referenceable): "zkapauthorizer_server_spending_successes", "ZKAP Spending Successes histogram", registry=self._registry, - buckets=self._get_buckets(), + buckets=self._get_spending_histogram_buckets(), ) def _clear_metrics(self): diff --git a/src/_zkapauthorizer/tests/test_storage_server.py b/src/_zkapauthorizer/tests/test_storage_server.py index 08bbc17..84f852a 100644 --- a/src/_zkapauthorizer/tests/test_storage_server.py +++ b/src/_zkapauthorizer/tests/test_storage_server.py @@ -145,7 +145,7 @@ def read_count(storage_server): def read_bucket(storage_server, size): - bounds = storage_server._get_buckets() + bounds = storage_server._get_spending_histogram_buckets() for bucket_number, upper_bound in enumerate(bounds): if size <= upper_bound: break -- GitLab