From 405fe58994ed9fe1b4fabf12c5ede22fa28cb30d Mon Sep 17 00:00:00 2001
From: Jean-Paul Calderone <exarkun@twistedmatrix.com>
Date: Mon, 13 Dec 2021 10:23:00 -0500
Subject: [PATCH] link to upstream issue about better testing APIs
---
src/_zkapauthorizer/tests/test_storage_server.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/_zkapauthorizer/tests/test_storage_server.py b/src/_zkapauthorizer/tests/test_storage_server.py
index 8ac558a..ad570cb 100644
--- a/src/_zkapauthorizer/tests/test_storage_server.py
+++ b/src/_zkapauthorizer/tests/test_storage_server.py
@@ -146,6 +146,8 @@ def read_spending_success_histogram_total(storage_server):
Read the total number of values across all buckets of the spending success
metric histogram.
"""
+ # Reading _buckets seems like the least bad option for now. See
+ # https://github.com/prometheus/client_python/issues/736 though.
buckets = storage_server._metric_spending_successes._buckets
return sum(b.get() for b in buckets)
@@ -166,6 +168,7 @@ def read_spending_success_histogram_bucket(storage_server, num_passes):
break
note("bucket_number {}".format(bucket_number))
+ # See note above about reading private _buckets attribute.
buckets = storage_server._metric_spending_successes._buckets
note(
"bucket counters: {}".format(list((n, b.get()) for n, b in enumerate(buckets)))
--
GitLab