From 61edf75e7f0f5ebcde4b290eae8914e2b92bd8ad Mon Sep 17 00:00:00 2001
From: Jean-Paul Calderone <exarkun@twistedmatrix.com>
Date: Mon, 6 Jan 2020 10:03:13 -0500
Subject: [PATCH] note for the future
---
src/_zkapauthorizer/lease_maintenance.py | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/_zkapauthorizer/lease_maintenance.py b/src/_zkapauthorizer/lease_maintenance.py
index fe8cb29..79d41cf 100644
--- a/src/_zkapauthorizer/lease_maintenance.py
+++ b/src/_zkapauthorizer/lease_maintenance.py
@@ -329,6 +329,12 @@ def lease_maintenance_service(
(interval_mean + halfrange).total_seconds(),
),
)
+ # Rather than an all-or-nothing last-run time we probably eventually want
+ # to have a more comprehensive record of the state when we were last
+ # interrupted. This would remove the unfortunate behavior of restarting
+ # from the beginning if we shut down during a lease scan. Shutting down
+ # during a lease scan becomes increasingly likely the more shares there
+ # are to check.
last_run = read_time_from_path(last_run_path)
if last_run is None:
initial_interval = sample_interval_distribution()
--
GitLab