From 80add9bf0ca8b202c3fd35e1eac647b47c2a69c7 Mon Sep 17 00:00:00 2001
From: Jean-Paul Calderone <exarkun@twistedmatrix.com>
Date: Thu, 2 Apr 2020 08:46:35 -0400
Subject: [PATCH] Get rid of this do-nothing function
It was doing to do some complex time math and decide if the voucher redemption
looked legit but the whole premise is broken.
The only thing you might be able to decide about a key change on a new voucher
is that some *older* ZKAPs might be suspicious. And, really, what you should
probably decide instead is that whole issuer is suspicious and you might need
to stop using it. On top of that, you need more information than what you get
from voucher redemptions. You need more frequent monitoring of the issuer's
key in case you don't redeem vouchers except once in a blue moon.
So hanging a suspiciousness on a voucher isn't coherent.
---
src/_zkapauthorizer/model.py | 25 +------------------------
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/src/_zkapauthorizer/model.py b/src/_zkapauthorizer/model.py
index b59e3a3..67ac95a 100644
--- a/src/_zkapauthorizer/model.py
+++ b/src/_zkapauthorizer/model.py
@@ -151,25 +151,6 @@ def memory_connect(path, *a, **kw):
return _connect(":memory:", *a, **kw)
-def determine_state_for_redeemed_voucher(existing_vouchers, redeemed, now):
- """
- Choose a state to store in the database for a voucher which was just
- redeemed.
-
- This takes into account what is known about previously redeemed vouchers
- (if any) and watches for suspicious public key changes in the redemption
- process.
-
- :param list[Voucher] existing_vouchers: Vouchers which have been redeemed
- in the past.
-
- :param Redeemed redeemed: The newly redeemed voucher's state.
-
- :param datetime now: The current time.
- """
- return u"redeemed"
-
-
@attr.s(frozen=True)
class VoucherStore(object):
"""
@@ -335,11 +316,7 @@ class VoucherStore(object):
:param list[UnblindedToken] unblinded_tokens: The unblinded tokens to
store.
"""
- voucher_state = determine_state_for_redeemed_voucher(
- None,
- None,
- None,
- )
+ voucher_state = u"redeemed"
cursor.execute(
"""
UPDATE [vouchers]
--
GitLab