From 95499ccfddf06482d362ea9844bcab2e2e29d10b Mon Sep 17 00:00:00 2001
From: Jean-Paul Calderone <exarkun@twistedmatrix.com>
Date: Sat, 9 May 2020 11:27:06 -0400
Subject: [PATCH] Avoid partially covered line in VoucherStore.add test
The 2nd get_tokens is never used so the line it is defined on is considered
partially covered. Replace the lambda with None and explain what's going on.
---
src/_zkapauthorizer/tests/test_model.py | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/src/_zkapauthorizer/tests/test_model.py b/src/_zkapauthorizer/tests/test_model.py
index 1670c54..e13856f 100644
--- a/src/_zkapauthorizer/tests/test_model.py
+++ b/src/_zkapauthorizer/tests/test_model.py
@@ -176,8 +176,23 @@ class VoucherStoreTests(TestCase):
in the same state as a single call.
"""
store = self.useFixture(TemporaryVoucherStore(get_config, lambda: now)).store
- first_tokens = store.add(voucher, len(tokens), 0, lambda: tokens)
- second_tokens = store.add(voucher, 0, 0, lambda: [])
+ first_tokens = store.add(
+ voucher,
+ expected_tokens=len(tokens),
+ counter=0,
+ get_tokens=lambda: tokens,
+ )
+ second_tokens = store.add(
+ voucher,
+ # The voucher should already exists in the store so the
+ # expected_tokens value supplied here is ignored.
+ expected_tokens=0,
+ counter=0,
+ # Likewise, no need to generate tokens here because counter value
+ # 0 was already added and tokens were generated then. If
+ # get_tokens were called here, it would be an error.
+ get_tokens=None,
+ )
self.assertThat(
store.get(voucher),
MatchesStructure(
--
GitLab