From 980215fb0a482b239cce090a99000f02036538dd Mon Sep 17 00:00:00 2001
From: Jean-Paul Calderone <exarkun@twistedmatrix.com>
Date: Tue, 23 Nov 2021 16:22:55 -0500
Subject: [PATCH] note a problem with this function that I don't want to deal
with now
---
src/_zkapauthorizer/storage_common.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/_zkapauthorizer/storage_common.py b/src/_zkapauthorizer/storage_common.py
index f890be6..554c355 100644
--- a/src/_zkapauthorizer/storage_common.py
+++ b/src/_zkapauthorizer/storage_common.py
@@ -211,6 +211,10 @@ def get_sharenums(tw_vectors):
:return set[int]: The share numbers which the given test/write vectors would write to.
"""
return set(
+ # This misses cases where `data` is empty but `new_length` is
+ # non-None, non-0.
+ #
+ # Related to #222.
sharenum for (sharenum, (test, data, new_length)) in tw_vectors.items() if data
)
--
GitLab