From ae42be0862c601f847a7dbd21608e06b1b915243 Mon Sep 17 00:00:00 2001 From: Jean-Paul Calderone <exarkun@twistedmatrix.com> Date: Mon, 25 May 2020 10:54:35 -0400 Subject: [PATCH] Nope, turns out we don't need to do that. --- src/_zkapauthorizer/_plugin.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/_zkapauthorizer/_plugin.py b/src/_zkapauthorizer/_plugin.py index fbc01e9..c0c157c 100644 --- a/src/_zkapauthorizer/_plugin.py +++ b/src/_zkapauthorizer/_plugin.py @@ -174,7 +174,12 @@ class ZKAPAuthorizer(object): from twisted.internet import reactor redeemer = self._get_redeemer(node_config, announcement, reactor) store = self._get_store(node_config) - # XXX Need to ensure one of these per store + + # Unlike our handling of the store, we make no effort to ensure there + # is only ever one SpendingController per database. + # SpendingController has no instance state so we can perfectly safely + # use several of them, pointing at the same underlying data set, + # concurrently without causing problems. controller = SpendingController.for_store( tokens_to_passes=redeemer.tokens_to_passes, store=store, -- GitLab