From ebf7a3bf5da8eb4858a89175c363203af174d45d Mon Sep 17 00:00:00 2001
From: Tom Prince <tom.prince@private.storage>
Date: Thu, 14 Oct 2021 15:04:14 -0600
Subject: [PATCH] Fix comments.
---
default.nix | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/default.nix b/default.nix
index f2bf583..a2c5e6c 100644
--- a/default.nix
+++ b/default.nix
@@ -9,6 +9,9 @@ in
let
providers = {
_default = "sdist,nixpkgs,wheel";
+ # mach-nix doesn't provide a good way to depend on mach-nix packages,
+ # so we get it as a nixpkgs dependency from an overlay. See below for
+ # details.
tahoe-lafs = "nixpkgs";
# not packaged in nixpkgs at all, we can use the binary wheel from
# pypi though.
@@ -51,11 +54,13 @@ in
name = "zero-knowledge-access-pass-authorizer";
src = ./.;
inherit providers;
- # We need to specify requirements here, since mach-nix does not
- # grab reqs from nixpkg dependencies
- # TODO: File issue
+ # mach-nix does not provide a way to specify dependencies on other
+ # mach-nix packages, that incorporates the requirements and overlays
+ # of that package.
+ # See https://github.com/DavHau/mach-nix/issues/123
+ # In particular, we explicitly include the requirements of tahoe-lafs
+ # here, and include it in a python package overlay.
requirementsExtra = tahoe-lafs.requirements;
- # Add
overridesPre = [
(
self: super: {
--
GitLab