hlint suggested improvements

test/SpecPersistence.hs

@@ -7,10 +7,6 @@
 
 module SpecPersistence where
 
-import Test.QuickCheck
-  ( Property
-  , (==>)
-  )
 import Control.Monad.IO.Class
   ( liftIO
   )
@@ -23,7 +19,9 @@ import Test.Hspec.Expectations
   ( shouldReturn
   )
 import Test.QuickCheck
-  ( property
+  ( Property
+  , property
+  , (==>)
   )
 import Test.QuickCheck.Monadic
   ( monadicIO
@@ -77,8 +75,9 @@ paidVoucherMismatchFingerprint getDB = property $ \voucher fingerprint fingerpri
   redeem fingerprint' `shouldReturn` Left AlreadyRedeemed
 
 makeSpec :: VoucherDatabase d => IO d -> Spec
-makeSpec getDB = do
-  describe "voucher interactions" $ do
+makeSpec getDB =
+  describe "voucher interactions" $
+  do
     it "denies redemption of a not-paid-for voucher" $ unpaidVoucherNotRedeemable getDB
     it "allows redemption of paid-for vouchers" $ paidVoucherRedeemable getDB
     it "allows multiple redemption as long as the same fingerprint is used" $ paidVoucherMultiRedeemable getDB

test/SpecStripe.hs

@@ -77,7 +77,7 @@ stripeAPI :: Proxy StripeAPI
 stripeAPI = Proxy
 
 app :: IO Application
-app = memory >>= return . stripeServer >>= return . serve stripeAPI
+app = serve stripeAPI . stripeServer <$> memory
 
 spec_webhook :: Spec
 spec_webhook = with app $ do

test/Util/Gen.hs

@@ -163,7 +163,7 @@ charges withVoucher =
   if withVoucher then
     metaDatasWithVoucher
   else
-    metaDatasWithVoucher
+    metaDatasWithoutVoucher
   )                     --   chargeMetaData :: MetaData
   <*> arbitrary         --   chargeStatementDescription :: Maybe StatementDescription
   <*> arbitrary         --   chargeReceiptEmail :: Maybe Text
@@ -184,4 +184,4 @@ posixTimes :: Gen UTCTime
 posixTimes = (arbitrary :: Gen Integer) `suchThatMap` (Just . posixSecondsToUTCTime . fromIntegral . abs)
 
 hasVoucher :: MetaData -> Bool
-hasVoucher (MetaData items) = any (== "Voucher") . (map fst) $ items
+hasVoucher (MetaData items) = elem "Voucher" . map fst $ items