Skip to content
Snippets Groups Projects
  • Jean-Paul Calderone's avatar
    0e0a84fd
    Remove redundant error-handling check · 0e0a84fd
    Jean-Paul Calderone authored
    This condition can never succeed.
    
    If the voucher is being seen for the first time at this point then it should
    start redemption and the check will not pass.
    
    If the voucher has been seen before and was in an error state to begin with
    then the check higher up, outside of the loop, prevents execution from ever
    entering the loop.
    
    If the voucher has been seen before and just now entered an error state then
    the `if not succeeded` check below, on the previous iteration, would stop the
    loop and prevent this condition from ever being checked.
    Remove redundant error-handling check
    Jean-Paul Calderone authored
    This condition can never succeed.
    
    If the voucher is being seen for the first time at this point then it should
    start redemption and the check will not pass.
    
    If the voucher has been seen before and was in an error state to begin with
    then the check higher up, outside of the loop, prevents execution from ever
    entering the loop.
    
    If the voucher has been seen before and just now entered an error state then
    the `if not succeeded` check below, on the previous iteration, would stop the
    loop and prevent this condition from ever being checked.