Skip to content
Snippets Groups Projects

Better lease renewal decisions

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: hacklschorsch

    Review: Approved

    LGTM!

    I find the code itself good to understand and pythonic; I can't make much sense of the tests.

    Maybe it's the combination of testtools with hypothesis. I fail to keep up with the many indirections.

  • Jean-Paul Calderone
  • Created by: codecov[bot]

    Codecov Report

    Merging #252 (3563169a) into main (d59a0b0a) will decrease coverage by 0.03%. The diff coverage is 85.41%.

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##             main     #252      +/-   ##
    ==========================================
    - Coverage   94.28%   94.24%   -0.04%     
    ==========================================
      Files          49       49              
      Lines        4096     4120      +24     
      Branches      517      526       +9     
    ==========================================
    + Hits         3862     3883      +21     
    - Misses        191      194       +3     
      Partials       43       43              
    Impacted Files Coverage Δ
    src/_zkapauthorizer/_storage_server.py 92.17% <75.00%> (+0.17%) :arrow_up:
    ...rc/_zkapauthorizer/tests/test_lease_maintenance.py 95.74% <83.87%> (-0.26%) :arrow_down:
    src/_zkapauthorizer/lease_maintenance.py 94.69% <100.00%> (+0.85%) :arrow_up:
    src/_zkapauthorizer/tests/matchers.py 97.91% <100.00%> (+0.24%) :arrow_up:
    src/_zkapauthorizer/resource.py 98.75% <0.00%> (-1.25%) :arrow_down:
    src/_zkapauthorizer/tests/test_model.py 92.44% <0.00%> (-0.45%) :arrow_down:

    Continue to review full report at Codecov.

    Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d59a0b0...3563169. Read the comment docs.

  • Please register or sign in to reply
    Loading