- May 11, 2020
-
-
Jean-Paul Calderone authored
Also centralize the exception-raising in one place
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
And update tests to take advantage of free equality we get
-
- May 09, 2020
-
-
Jean-Paul Calderone authored
The 2nd get_tokens is never used so the line it is defined on is considered partially covered. Replace the lambda with None and explain what's going on.
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
- May 08, 2020
-
-
Jean-Paul Calderone authored
This condition can never succeed. If the voucher is being seen for the first time at this point then it should start redemption and the check will not pass. If the voucher has been seen before and was in an error state to begin with then the check higher up, outside of the loop, prevents execution from ever entering the loop. If the voucher has been seen before and just now entered an error state then the `if not succeeded` check below, on the previous iteration, would stop the loop and prevent this condition from ever being checked.
-
Jean-Paul Calderone authored
-
- May 06, 2020
-
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
They're not primarily about super-largeness and super-large files prevent them from working on Windows.
-
- May 05, 2020
-
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
No one is going to run a storage server on Windows anyway
-
- May 04, 2020
-
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
- May 01, 2020
-
-
Jean-Paul Calderone authored
Compute it ourselves so it is correct for large files
-
Jean-Paul Calderone authored
This makes the test a little more challenging by adding some more bookkeeping overhead that needs to be accounted for.
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
This removes almost all uses of the global value. All that remains is its use as a default in case no configuration is given.
-
Jean-Paul Calderone authored
This makes the database responsible for remembering how many tokens we expect to get for a voucher, rather than the in-memory Python state or the code. As a result, we can resume redemption knowing the correct number of tokens after a process restart and without relying on the PaymentController's default token count to have remained unchanged.
-
- Apr 30, 2020
-
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
- Apr 29, 2020
-
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
This makes the tests faster and avoids hypothesis complaints about assumptions that fail too often.
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
- Apr 28, 2020
-
-
Jean-Paul Calderone authored
Redeem the voucher once for each redemption group. Track progress in the database. Delay entering the "redeemed" state until all groups have succeeded.
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
This gives us more tokens than there are redemption groups, a requirement
-
Jean-Paul Calderone authored
-
Jean-Paul Calderone authored
They must use at least as many tokens as there are redemption groups
-